linux-kernel - Re: [PATCH v3] i2c: designware: call i2c_dw_read_clear_intrbits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a44aacbb-fcb4-f83f-b781-b69f52944f09@linux.intel.com>
Date:   Fri, 23 Oct 2020 09:27:07 +0300
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     Michael Wu <michael.wu@...ics.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Morgan Chang <morgan.chang@...ics.com>
Subject: Re: [PATCH v3] i2c: designware: call
 i2c_dw_read_clear_intrbits_slave() once

On 10/23/20 8:40 AM, Michael Wu wrote:
> If some bits were cleared by i2c_dw_read_clear_intrbits_slave() in
> i2c_dw_isr_slave() and not handled immediately, those cleared bits would
> not be shown again by later i2c_dw_read_clear_intrbits_slave(). They
> therefore were forgotten to be handled.
> 
> i2c_dw_read_clear_intrbits_slave() should be called once in an ISR and take
> its returned state for all later handlings.
> 
> Signed-off-by: Michael Wu <michael.wu@...ics.com>
> ---
> 
> Change in v3:
>   - revert deleted braces of 'else' branch in v2
> 
> Change in v2:
>   - revert moving I2C_SLAVE_WRITE_REQUESTED reporting in v1
> 
>   drivers/i2c/busses/i2c-designware-slave.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>