linux-kernel - Re: [PATCH v3 0/3] HDA controller PM and codec PM cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h1rhixhsk.wl-tiwai@suse.de>
Date:   Wed, 28 Oct 2020 20:38:19 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     tiwai@...e.com, perex@...ex.cz, hui.wang@...onical.com,
        kai.vehmanen@...ux.intel.com, mwolf@...umentum.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/3] HDA controller PM and codec PM cleanups

On Tue, 27 Oct 2020 14:00:35 +0100,
Kai-Heng Feng wrote:
> 
> While working on the issue "ALSA: hda: fix jack detection with Realtek
> codecs when in D3", I've found using pm_runtime_force_{suspend,resume}()
> have surprising behavior, specifically, pm_runtime_need_not_resume()
> uses pm_runtime_need_not_resume() to avoid calling resume callback, so
> jackpoll was used to really power up the codec.
> 
> We can use direct-complete to do the keep the codec suspended throughout
> the system PM flow, namely, keep the codec suspended all the way, unless
> the codec needs to be woken up after resume.
> 
> For HDA controller, PCI core may enable direct-complete for it if
> conditions are met. So make runtime and system PM distinctive to always
> apply correct wake up setting.
> 
> At least point, hopefully all runtime PM issues are solved, let's enable
> runtime PM by default again.
> 
> v3:
>  - Drop "ALSA: hda: Stop mangling PCI IRQ"
> 
> Kai-Heng Feng (3):
>   ALSA: hda: Refactor codec PM to use direct-complete optimization
>   ALSA: hda: Separate runtime and system suspend
>   ALSA: hda: Reinstate runtime_allow() for all hda controllers

Now I applied all three patches.
Since it's a nice improvement, I'm going to push to 5.10.


thanks,

Takashi