linux-kernel - Re: [tip: x86/seves] x86/vmware: Add VMware-specific handling for VMMCALL under SEV-ES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201028095424.GJ22179@suse.de>
Date:   Wed, 28 Oct 2020 10:54:24 +0100
From:   Joerg Roedel <jroedel@...e.de>
To:     Erdem Aktas <erdemaktas@...gle.com>, dcovelli@...are.com
Cc:     linux-kernel@...r.kernel.org,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        linux-tip-commits@...r.kernel.org, Borislav Petkov <bp@...e.de>,
        x86 <x86@...nel.org>
Subject: Re: [tip: x86/seves] x86/vmware: Add VMware-specific handling for
 VMMCALL under SEV-ES

On Tue, Oct 27, 2020 at 04:19:45PM -0700, Erdem Aktas wrote:
> Looking at the VMWARE_VMCALL(cmd, eax, ebx, ecx, edx) definition, it
> seems to me only 4 registers are required to be shared with
> hypervisor. I don't know much about vmware but is not
> vmware_sev_es_hcall_prepare expose more registers than needed and also
> vmware_sev_es_hcall_finish might let the hypvervisor to modify
> additional registers which are not used?
> 
> Just checking if this is intentional and what I am missing here.

Original patch is from Doug, maybe he can clarify what needs to be
shared. I only adapted it to the call-backs.

Doug?

Regards,

	Joerg