linux-kernel - Re: [f2fs-dev] [PATCH v5 1/2] f2fs: add F2FS_IOC_GET_COMPRESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Oct 2020 10:37:45 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Daeho Jeong <daeho43@...il.com>, <linux-kernel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>, <kernel-team@...roid.com>
CC:     Daeho Jeong <daehojeong@...gle.com>
Subject: Re: [f2fs-dev] [PATCH v5 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION
 ioctl

On 2020/10/29 15:24, Chao Yu wrote:
> On 2020/10/29 12:15, Daeho Jeong wrote:

>> +	inode_lock(inode);
> 
> It's minor,
> 
> inode_lock_shared()?
> 
>> +
>> +	if (!f2fs_compressed_file(inode)) {
>> +		inode_unlock(inode);
> 
> inode_unlock_shared()?
> 
>> +		return -ENODATA;
>> +	}
>> +
>> +	option.algorithm = F2FS_I(inode)->i_compress_algorithm;
>> +	option.log_cluster_size = F2FS_I(inode)->i_log_cluster_size;
>> +
>> +	inode_unlock(inode);
> 
> ditto.

Any comments?

Thanks,