linux-kernel - Re: [f2fs-dev] [PATCH v5 1/2] f2fs: add F2FS_IOC_GET_COMPRESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACOAw_xHM-FB3pRfFnjF-9eVgo=cxPh=tsLyEX30NHaz2gAbtQ@mail.gmail.com>
Date:   Fri, 30 Oct 2020 12:25:06 +0900
From:   Daeho Jeong <daeho43@...il.com>
To:     Chao Yu <yuchao0@...wei.com>
Cc:     linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net, kernel-team@...roid.com,
        Daeho Jeong <daehojeong@...gle.com>
Subject: Re: [f2fs-dev] [PATCH v5 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

Opps, I missed this.
We need v7... lol

2020년 10월 30일 (금) 오전 11:37, Chao Yu <yuchao0@...wei.com>님이 작성:
>
> On 2020/10/29 15:24, Chao Yu wrote:
> > On 2020/10/29 12:15, Daeho Jeong wrote:
>
> >> +    inode_lock(inode);
> >
> > It's minor,
> >
> > inode_lock_shared()?
> >
> >> +
> >> +    if (!f2fs_compressed_file(inode)) {
> >> +            inode_unlock(inode);
> >
> > inode_unlock_shared()?
> >
> >> +            return -ENODATA;
> >> +    }
> >> +
> >> +    option.algorithm = F2FS_I(inode)->i_compress_algorithm;
> >> +    option.log_cluster_size = F2FS_I(inode)->i_log_cluster_size;
> >> +
> >> +    inode_unlock(inode);
> >
> > ditto.
>
> Any comments?
>
> Thanks,