linux-kernel - Re: [PATCH 4.14 v2 ] platform/x86: Corrects warning: missing braces around initializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201030165227.GR4077@smile.fi.intel.com>
Date:   Fri, 30 Oct 2020 18:52:27 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     john.p.donnelly@...cle.com
Cc:     linux-kernel@...r.kernel.org, trix@...hat.com
Subject: Re: [PATCH 4.14 v2 ] platform/x86: Corrects warning: missing braces
 around initializer

On Fri, Oct 30, 2020 at 08:55:01AM -0700, john.p.donnelly@...cle.com wrote:
> From: John Donnelly <john.p.donnelly@...cle.com>
> 
> The assignment statement of a local variable "struct tp_nvram_state s[2] = {0};
> is not valid for all versions of compilers.

I don't get the subject. IS it backport of existing change to v4.14, or you are
trying to fix v4.14? If the latter is the case, it's not correct order. Try
latest vanilla first (v5.10-rc1 as of today) and if there is still an issue,
submit a patch.

> Fixes: 515ded02bc4b ("platform/x86: thinkpad_acpi: initialize tp_nvram_state variable")
> 
> Signed-off-by: John Donnelly <john.p.donnelly@...cle.com>

Should not be blank line in between.

-- 
With Best Regards,
Andy Shevchenko