lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 30 Oct 2020 18:22:10 -0400
From:   Willem de Bruijn <>
To:     Xie He <>
Cc:     Willem de Bruijn <>,
        Jakub Kicinski <>,
        "David S. Miller" <>,
        Network Development <>,
        linux-kernel <>,
        Krzysztof Halasa <>
Subject: Re: [PATCH net-next v4 4/5] net: hdlc_fr: Do skb_reset_mac_header for
 skbs received on normal PVC devices

On Fri, Oct 30, 2020 at 5:49 PM Xie He <> wrote:
> On Fri, Oct 30, 2020 at 2:28 PM Willem de Bruijn
> <> wrote:
> >
> > Yes, it might require holding off the other patches until net is
> > merged into net-next.
> >
> > Packet sockets are likely not the only way these packets are received?
> > It changes mac_len as computed in __netif_receive_skb_core.
> I looked at __netif_receive_skb_core. I didn't see it computing mac_len?

It's indirect:

        if (!skb_transport_header_was_set(skb))

> I thought only AF_PACKET/RAW sockets would need this information
> because other upper layers would not care about what happened in L2.

I think that's a reasonable assumption. I don't have a good
counterexample ready. Specific to this case, it seems to have been
working with no one complaining so far ;)

> I see mac_len is computed in netif_receive_generic_xdp. I'm not clear
> about the reason why it calculates it. But it seems that it considers
> the L2 header as an Ethernet header, which is incorrect for this
> driver.
> > If there is no real bug that is fixed, net-next is fine.

Powered by blists - more mailing lists