| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 30 Oct 2020 10:37:34 +0530
From: Akhil P Oommen <akhilpo@...eaurora.org>
To: mka@...omium.org
Cc: devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
dianders@...omium.org, linux-kernel@...r.kernel.org,
dri-devel@...edesktop.org, freedreno@...ts.freedesktop.org
Subject: Re: [v4,1/3] drm/msm: Add support for GPU cooling
On 10/30/2020 2:18 AM, mka@...omium.org wrote:
> On Thu, Oct 29, 2020 at 01:37:19PM +0530, Akhil P Oommen wrote:
>> Register GPU as a devfreq cooling device so that it can be passively
>> cooled by the thermal framework.
>>
>> Signed-off-by: Akhil P Oommen <akhilpo@...eaurora.org>
>> Reviewed-by: Matthias Kaehlcke <mka@...omium.org>
>
> Wait, I did not post a 'Reviewed-by' tag for this patch!
>
> I think the patch should be ok, but I'm still not super happy
> about the resource management involving devfreq in general (see
> discussion on https://patchwork.freedesktop.org/patch/394291/?series=82476&rev=1).
> It's not really something introduced by this patch, but if it ever
> gets fixed releasing the cooling device at the end of
> msm_gpu_cleanup() after everything else might cause trouble.
>
> In summary, I'm supportive of landing this patch, but reluctant to
> 'sign it off' because of the above.
>
> In any case:
>
> Tested-by: Matthias Kaehlcke <mka@...omium.org>
Sorry, Matthias. My mistake. You shared the reviewed tag for the
dt-bindings update. Will fix this ASAP. Thanks for verifying this.
-Akhil.
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
Powered by blists - more mailing lists