linux-kernel - Re: [PATCH v2 4/5] usb: dwc3: debugfs: Introduce DEFINE_SHOW_STORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Oct 2020 10:59:18 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Luo Jiaxing <luojiaxing@...wei.com>, akpm@...ux-foundation.org,
        viro@...iv.linux.org.uk, andriy.shevchenko@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org, martin.petersen@...cle.com,
        john.garry@...wei.com, himanshu.madhani@...ium.com,
        gregkh@...uxfoundation.org, uma.shankar@...el.com,
        anshuman.gupta@...el.com, animesh.manna@...el.com,
        linux-usb@...r.kernel.org, linux-scsi@...r.kernel.org,
        linuxarm@...wei.com
Subject: Re: [PATCH v2 4/5] usb: dwc3: debugfs: Introduce
 DEFINE_SHOW_STORE_ATTRIBUTE

Luo Jiaxing <luojiaxing@...wei.com> writes:

> Seq instroduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE for
      ^^^^^^^^^^              ^^^^^
      introduce               macro

> Read-Write file, So we apply it at dwc3 debugfs to reduce some duplicate
                   ^^                                            ^^^^^^^^^
                   so                                            duplicated

> code.

to be fair, your commit is doing more than what it claims. Maybe update
commit log with a "while at that, also use DEFINE_SHOW_ATTRIBUTE() where
possible".

> Signed-off-by: Luo Jiaxing <luojiaxing@...wei.com>

other than that, this looks okay. Since it depends on the definition of
DEFINE_SHOW_STORE_ATTRIBUTE:

Acked-by: Felipe Balbi <balbi@...nel.org>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (858 bytes)