linux-kernel - Re: [PATCH] ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a2dxGV4ussfC16XN98xeSwsKum=Hu8_GJ+E3ZS=wu8oYw@mail.gmail.com>
Date:   Fri, 30 Oct 2020 11:01:20 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     Nishanth Menon <nm@...com>, Tony Lindgren <tony@...mide.com>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        linux-omap <linux-omap@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sekhar Nori <nsekhar@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH] ARM: multi_v7_defconfig: ti: Enable networking options
 for nfs boot

On Fri, Oct 30, 2020 at 10:36 AM Grygorii Strashko
<grygorii.strashko@...com> wrote:
> On 29/10/2020 22:06, Arnd Bergmann wrote:
> >>
> >> Are there any actions need to be done to have this patch merged?
> >
> > I would prefer if a platform maintainer (I assume Tony in this case)
> > picks it up and forwards it to soc@...nel.org together with other
> > related changes. Olof and I tend to ignore patches sent directly
> > to us, so we don't get in the way of platform maintainers that
> > may have already merged similar patches or have comments.
> >
> > I suspect Tony didn't pick it up either because from the patch
> > subject and the description, it is not clear that he is the one
> > to act on it. It helps to be more specific and ask the maintainer
> > by addressing them in person below the '---' line, as well as
> > only putting one person in 'To:' and the rest in 'Cc:'.
>
> Thanks for your comments and sorry that I disturbed you.
>
> But, honestly, I'm confused (and probably I'm not the first one) as multi_v7 is common
> for all ARM platforms while change is TI OMAP specific,
> and neither Documentation neither get_maintainer.pl provide any reliable information
> on how to proceed :( and who should be responsible for merging multi_x patches.
>
> I'd really have tried to do some checking while preparing patch and TO/CC list -
> some patches applied by platform maintainers, but some by top ARM maintainers.

I understand that this is confusion, and we should probably come up
with a better way to handle it.

To clarify further, while we prefer the patches to be picked up by the
platform maintainers and forwarded to us for patches to the common
files that are needed for a particular platform, you can also send these
patches directly to soc@...nel.org, which puts them into patchwork
at https://patchwork.kernel.org/project/linux-soc/list/. Once it's in
there, we will process it by merging the patch or getting back to you
for further clarification.

> > One comment on the contents of the patch: IIRC this is a fairly
> > large driver. To ensure we don't burden other users too much,
> > can you include the size of the vmlinux file before and after
> > this patch?
>
> before:
>     text           data     bss     dec     hex filename
> 14703736        8024602  444976 23173314        16198c2 ./omap-arm/vmlinux
>
> after:
>     text           data     bss     dec     hex filename
> 14727271        8029150  444528 23200949        16204b5 ./omap-arm/vmlinux
>
> diff: 27635 (dec)

Ok, that doesn't look too bad, though the total size is definitely worrying.
Please include the above in the changelog text.

       Arnd