linux-kernel - Re: [PATCH v4] iio: proximity: vl53l0x-i2c add i2c_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201101151612.71c3fa1b@archlinux>
Date:   Sun, 1 Nov 2020 15:16:12 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Vaishnav M A <vaishnav@...gleboard.org>
Cc:     andy.shevchenko@...il.com, wsa@...nel.org,
        songqiang1304521@...il.com, knaack.h@....de, lars@...afoo.de,
        alexandru.ardelean@...log.com, matt.ranostay@...sulko.com,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        jkridner@...gleboard.org, drew@...gleboard.org,
        robertcnelson@...gleboard.org, rajkovic@...roe.com
Subject: Re: [PATCH v4] iio: proximity: vl53l0x-i2c add i2c_device_id

On Mon, 19 Oct 2020 01:21:02 +0530
Vaishnav M A <vaishnav@...gleboard.org> wrote:

> Add i2c_device_id table for the vl53l0x-i2c driver,
> helps in device instantiation using i2c_new_client_device()
> or from userspace in cases where device-tree based description
> is not possible now, like device(s) on a gbphy i2c adapter
> created by greybus.
> 
> Signed-off-by: Vaishnav M A <vaishnav@...gleboard.org>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see if they can find any issues.

Thanks,

Jonathan

> 
> ---
>  v4:
> 	-update commit message, add punctuation
>  v3:
> 	-modify commit message for readability
> 	 as suggested by Jonathan Cameron
>  v2:
> 	-fix commit message
>  drivers/iio/proximity/vl53l0x-i2c.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/proximity/vl53l0x-i2c.c b/drivers/iio/proximity/vl53l0x-i2c.c
> index 5fbda9475ba9..7c29d4cae24a 100644
> --- a/drivers/iio/proximity/vl53l0x-i2c.c
> +++ b/drivers/iio/proximity/vl53l0x-i2c.c
> @@ -143,6 +143,12 @@ static int vl53l0x_probe(struct i2c_client *client)
>  	return devm_iio_device_register(&client->dev, indio_dev);
>  }
>  
> +static const struct i2c_device_id vl53l0x_id[] = {
> +	{ "vl53l0x", 0},
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, vl53l0x_id);
> +
>  static const struct of_device_id st_vl53l0x_dt_match[] = {
>  	{ .compatible = "st,vl53l0x", },
>  	{ }
> @@ -155,6 +161,7 @@ static struct i2c_driver vl53l0x_driver = {
>  		.of_match_table = st_vl53l0x_dt_match,
>  	},
>  	.probe_new = vl53l0x_probe,
> +	.id_table = vl53l0x_id,
>  };
>  module_i2c_driver(vl53l0x_driver);
>