linux-kernel - RE: [EXT] [PATCH] scsi: bnx2fc: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR18MB30341EB96B8A82BA6FAF9408D2100@DM6PR18MB3034.namprd18.prod.outlook.com>
Date:   Mon, 2 Nov 2020 04:44:11 +0000
From:   Saurav Kashyap <skashyap@...vell.com>
To:     "trix@...hat.com" <trix@...hat.com>,
        Javed Hasan <jhasan@...vell.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH] scsi: bnx2fc: remove unneeded semicolon

Hi Tom,

> -----Original Message-----
> From: trix@...hat.com <trix@...hat.com>
> Sent: Sunday, November 1, 2020 8:08 PM
> To: Saurav Kashyap <skashyap@...vell.com>; Javed Hasan
> <jhasan@...vell.com>; jejb@...ux.ibm.com; martin.petersen@...cle.com
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@...vell.com>; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org; Tom Rix <trix@...hat.com>
> Subject: [EXT] [PATCH] scsi: bnx2fc: remove unneeded semicolon
> 
> External Email
> 
> ----------------------------------------------------------------------
> From: Tom Rix <trix@...hat.com>
> 
> A semicolon is not needed after a switch statement.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> index 6890bbe04a8c..a436adb6092d 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> @@ -2275,7 +2275,7 @@ static int bnx2fc_ctlr_enabled(struct
> fcoe_ctlr_device *cdev)
>  	case FCOE_CTLR_UNUSED:
>  	default:
>  		return -ENOTSUPP;
> -	};
> +	}
>  }

Thanks for a patch.

Reviewed-by: Saurav Kashyap <skashyap@...vell.com>

Thanks,
~Saurav
> 
>  enum bnx2fc_create_link_state {
> --
> 2.18.1