linux-kernel - Re: [PATCH] cpufreq: mediatek: add missing platform_driver_unregister() on error in mtk_cpufreq_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201102044636.2hwblwjxrfll6w5h@vireshk-i7>
Date:   Mon, 2 Nov 2020 10:16:36 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Qinglang Miao <miaoqinglang@...wei.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] cpufreq: mediatek: add missing
 platform_driver_unregister() on error in mtk_cpufreq_driver_init

On 31-10-20, 09:18, Qinglang Miao wrote:
> Add the missing platform_driver_unregister() before return from
> mtk_cpufreq_driver_init in the error handling case when failed
> to register mtk-cpufreq platform device
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---
>  drivers/cpufreq/mediatek-cpufreq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> index 7d1212c9b..c03c76a0c 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -572,6 +572,7 @@ static int __init mtk_cpufreq_driver_init(void)
>  	pdev = platform_device_register_simple("mtk-cpufreq", -1, NULL, 0);
>  	if (IS_ERR(pdev)) {
>  		pr_err("failed to register mtk-cpufreq platform device\n");
> +		platform_driver_unregister(&mtk_cpufreq_platdrv);
>  		return PTR_ERR(pdev);
>  	}

Applied. Thanks.

-- 
viresh