linux-kernel - Re: [PATCH 2/2] regulator: Add support for DA9121 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201102154848.tm5nsydaukyd7rrw@axis.com>
Date:   Mon, 2 Nov 2020 16:48:48 +0100
From:   Vincent Whitchurch <vincent.whitchurch@...s.com>
To:     Mark Brown <broonie@...nel.org>
CC:     <lgirdwood@...il.com>, <support.opensource@...semi.com>,
        <kernel@...s.com>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <robh+dt@...nel.org>
Subject: Re: [PATCH 2/2] regulator: Add support for DA9121 regulator

On Thu, Oct 29, 2020 at 03:28:43PM +0000, Mark Brown wrote:
> On Thu, Oct 29, 2020 at 04:15:38PM +0100, Vincent Whitchurch wrote:
> 
> > +	config.init_data = of_get_regulator_init_data(dev, dev->of_node, &da9121_reg);
> > +	if (!config.init_data)
> > +		return -ENOMEM;
> 
> Don't do this, the core can do the DT bit for you and there is no reason
> not to register the device if there are no constraints.  -ENOMEM would
> also be the wrong error code here.

OK, thanks.  I see that I can get the core to do it if I set ->of_match
on the regulator_desc.  I also see that there is some flexibility about
the placement of the constraints (desc->regulators_node is optional).

This chip has only one output which the datasheet calls Buck1, so I will
remove this call and set the desc.of_match field to get the driver to
support a node which looks like this:

      regulator@68 {
        compatible = "dlg,da9121";
        reg = <0x68>;

        buck1 {
            regulator-min-microvolt = <675000>;
            regulator-max-microvolt = <825000>;
        };
      };