linux-kernel - Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 03 Nov 2020 18:12:51 +0100
From:   Lukasz Stelmach <l.stelmach@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>, Kukjin Kim <kgene@...nel.org>,
        Anand Moon <linux.amoon@...il.com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bartłomiej Żolnierkiewicz 
        <b.zolnierkie@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface
 description for Odroid X/X2

It was <2020-11-03 wto 17:44>, when Krzysztof Kozlowski wrote:
> On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
>> Add Ethernet interface description for Odroid X/X2.
>> 
>> Signed-off-by: Łukasz Stelmach <l.stelmach@...sung.com>
>> ---
>>  arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> index 3ea2a0101e80..8f154f431f6c 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
>> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> @@ -15,6 +15,10 @@ / {
>>  	model = "Hardkernel ODROID-X board based on Exynos4412";
>>  	compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
>>  
>> +	aliases {
>> +		ethernet = &ethernet;
>> +	};
>> +
>>  	memory@...00000 {
>>  		device_type = "memory";
>>  		reg = <0x40000000 0x3FF00000>;
>> @@ -72,8 +76,32 @@ &buck8_reg {
>>  };
>>  
>>  &ehci {
>> +	#address-cells = <1>;
>> +	#size-cells = <0>;
>>  	phys = <&exynos_usbphy 2>;
>>  	phy-names = "hsic0";
>> +
>> +	hub@2 {
>> +		compatible = "usb0424,3503";
>> +		reg = <2>;
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		hub@1 {
>> +			compatible = "usb0424:9514";
>
> Does not look like correct compatible.

As odd as it may seem (and considering my mistakes) this is correct.

--8<---------------cut here---------------start------------->8---
root@...get:~# cat /proc/device-tree/compatible ; echo
hardkernel,odroid-x2samsung,exynos4412samsung,exynos4
root@...get:~# lsusb -t
/:  Bus 01.Port 1: Dev 1, Class=root_hub, Driver=exynos-ehci/3p, 480M
    |__ Port 2: Dev 2, If 0, Class=Hub, Driver=hub/3p, 480M
        |__ Port 1: Dev 3, If 0, Class=Hub, Driver=hub/5p, 480M
            |__ Port 1: Dev 4, If 0, Class=Vendor Specific Class, Driver=smsc95xx, 480M
root@...get:~# lsusb
Bus 001 Device 004: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter
Bus 001 Device 003: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub
Bus 001 Device 002: ID 0424:3503 Standard Microsystems Corp. 
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
--8<---------------cut here---------------end--------------->8---

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

Download attachment "signature.asc" of type "application/pgp-signature" (488 bytes)