linux-kernel - Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPdTU74P6PDqPqoW-qF3QkvK_0wXCVSUeuExfQyHZdvcpg@mail.gmail.com>
Date:   Tue, 3 Nov 2020 18:22:39 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Lukasz Stelmach <l.stelmach@...sung.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Kukjin Kim <kgene@...nel.org>,
        Anand Moon <linux.amoon@...il.com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bartłomiej Żolnierkiewicz 
        <b.zolnierkie@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description
 for Odroid X/X2

On Tue, 3 Nov 2020 at 18:13, Lukasz Stelmach <l.stelmach@...sung.com> wrote:
>
> It was <2020-11-03 wto 17:44>, when Krzysztof Kozlowski wrote:
> > On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
> >> Add Ethernet interface description for Odroid X/X2.
> >>
> >> Signed-off-by: Łukasz Stelmach <l.stelmach@...sung.com>
> >> ---
> >>  arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
> >>  1 file changed, 28 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> index 3ea2a0101e80..8f154f431f6c 100644
> >> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> @@ -15,6 +15,10 @@ / {
> >>      model = "Hardkernel ODROID-X board based on Exynos4412";
> >>      compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
> >>
> >> +    aliases {
> >> +            ethernet = &ethernet;
> >> +    };
> >> +
> >>      memory@...00000 {
> >>              device_type = "memory";
> >>              reg = <0x40000000 0x3FF00000>;
> >> @@ -72,8 +76,32 @@ &buck8_reg {
> >>  };
> >>
> >>  &ehci {
> >> +    #address-cells = <1>;
> >> +    #size-cells = <0>;
> >>      phys = <&exynos_usbphy 2>;
> >>      phy-names = "hsic0";
> >> +
> >> +    hub@2 {
> >> +            compatible = "usb0424,3503";
> >> +            reg = <2>;
> >> +            #address-cells = <1>;
> >> +            #size-cells = <0>;
> >> +
> >> +            hub@1 {
> >> +                    compatible = "usb0424:9514";
> >
> > Does not look like correct compatible.
>
> As odd as it may seem (and considering my mistakes) this is correct.

Not the numbers, the format. Comma is needed.

Best regards,
Krzysztof