lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Nov 2020 12:47:39 -0600 From: Segher Boessenkool <segher@...nel.crashing.org> To: Borislav Petkov <bp@...en8.de> Cc: shuo.a.liu@...el.com, linux-kernel@...r.kernel.org, x86@...nel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "H . Peter Anvin" <hpa@...or.com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Sean Christopherson <sean.j.christopherson@...el.com>, Yu Wang <yu1.wang@...el.com>, Reinette Chatre <reinette.chatre@...el.com>, Yakui Zhao <yakui.zhao@...el.com>, Dave Hansen <dave.hansen@...el.com>, Dan Williams <dan.j.williams@...el.com>, Fengwei Yin <fengwei.yin@...el.com>, Zhi Wang <zhi.a.wang@...el.com>, Zhenyu Wang <zhenyuw@...ux.intel.com>, Arvind Sankar <nivedita@...m.mit.edu>, Peter Zijlstra <peterz@...radead.org>, Nick Desaulniers <ndesaulniers@...gle.com> Subject: Re: [PATCH v5 04/17] x86/acrn: Introduce hypercall interfaces On Tue, Nov 03, 2020 at 05:44:35PM +0100, Borislav Petkov wrote: > On Mon, Nov 02, 2020 at 05:18:09PM -0600, Segher Boessenkool wrote: > > That is invalid actually: local register asm as input to an inline asm > > should use *that* register! > > > > This is all correct until LRA ("reload"). Not that "movl %xmm0,$eax" > > works, but at least it screams its head off, as it should. > > Screams how? $ cat xmm1.s movl %xmm0,%eax $ x86_64-linux-as xmm1.s -o xmm1.o xmm1.s: Assembler messages: xmm1.s:1: Error: unsupported instruction `mov' (This isn't an existing insn IIUC.) > It builds fine without a single peep with -Wall here. > > Btw, that's a MOVD - not a MOVL. MOVD can do xmm -> gpr moves. And > singlestepping it with gdb does, well, something, which is clearly > wrong but nothing complains: > > => 0x555555555131 <main+12>: movd %xmm0,%eax > > and %xmm0 has: > > (gdb) p $xmm0 > $2 = {v4_float = {0.99000001, 0, 0, 0}, v2_double = {5.2627153433055495e-315, 0}, v16_int8 = {-92, 112, 125, 63, > ^^^^^^^^^^ > > so that is correct. The original code had movl. And movl is needed for GPRs. > and that same value goes into %r8d: > > mov %eax,%r8d Which violates what is required by register asm :-( > > Yes. But GCC doing what you should have said instead of doing what you > > said, is not good. > > Oh well, should I open a low prio bug, would that help? Sure, thanks! > I probably should test with the latest gcc first, though... Yeah... FWIW, I tested with x86_64-linux-gcc (GCC) 11.0.0 20201015 (experimental) so I doubt current ToT will have it fixed, but who knows. Thanks, Segher
Powered by blists - more mailing lists