linux-kernel - Re: support splice reads on seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wha+F9-my8=3KO7TNJ7r-fVobMrXRdUuSs5c2bbqk1edA@mail.gmail.com>
Date:   Tue, 3 Nov 2020 10:57:10 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Greg KH <gregkh@...uxfoundation.org>,
        Alexey Dobriyan <adobriyan@...il.com>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: support splice reads on seq_file based procfs files

On Tue, Nov 3, 2020 at 10:48 AM Christoph Hellwig <hch@....de> wrote:
>
> ping?

It looked fine by me, although honestly, I'd prefer that last patch to
be the minimum possible if we want this for 5.10.

Yeah, that might technically be just cpuinfo, but I'd be ok with the
other read-only core proc files (ie I would *not* add it to anything
that has a .proc_write operation like the ones in proc_net.c).

IOW, I'd start with just cpuinfo_proc_ops, proc_seq_ops,
proc_single_ops, and stat_proc_ops.

Because honestly, I'd rather restrict splice() as much as possible
than try to say "everything should be able to do splice".

Hmm?

               Linus