linux-kernel - Re: [PATCH v2] fs/aio.c: Cosmetic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35625559ea6fa7827e840905a4a03e624fdeb43f.camel@perches.com>
Date:   Mon, 02 Nov 2020 19:22:57 -0800
From:   Joe Perches <joe@...ches.com>
To:     Andreas Dilger <adilger@...ger.ca>,
        Alejandro Colomar <colomar.6.4.3@...il.com>
Cc:     Benjamin LaHaise <bcrl@...ck.org>, linux-aio@...ck.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fs/aio.c: Cosmetic

On Mon, 2020-11-02 at 17:50 -0700, Andreas Dilger wrote:
> On Nov 2, 2020, at 2:58 PM, Alejandro Colomar <colomar.6.4.3@...il.com> wrote:
> > Changes:
> > - Consistently use 'unsigned int', instead of 'unsigned'.
> > - Add a blank line after variable declarations.
> > - Move variable declarations to the top of functions.
> > - Add a blank line at the top of functions if there are no declarations.
> 
> I'd agree that the other changes are following kernel coding style, but
> I've never heard of leaving a blank line at the start of functions without
> any local variables.

I think that is odd as well.

> I don't see anything in process/coding-style.rst to
> support this change, nor are the majority of variable-less functions
> formatted this way, and it seems to just be a waste of vertical space.

checkpatch emits a --strict CHECK for those blank lines after
open braces


CHECK: Blank lines aren't necessary after an open brace '{'
#200: FILE: fs/aio.c:256:
 {
+

CHECK: Blank lines aren't necessary after an open brace '{'
#246: FILE: fs/aio.c:370:
 {
+

etc...