linux-kernel - Re: [PATCH v2] fs/aio.c: Cosmetic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7CCB9FA6-DE85-4E3F-B3F1-7144F01589D4@dilger.ca>
Date:   Mon, 2 Nov 2020 17:50:46 -0700
From:   Andreas Dilger <adilger@...ger.ca>
To:     Alejandro Colomar <colomar.6.4.3@...il.com>
Cc:     Benjamin LaHaise <bcrl@...ck.org>, linux-aio@...ck.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fs/aio.c: Cosmetic

On Nov 2, 2020, at 2:58 PM, Alejandro Colomar <colomar.6.4.3@...il.com> wrote:
> Changes:
> - Consistently use 'unsigned int', instead of 'unsigned'.
> - Add a blank line after variable declarations.
> - Move variable declarations to the top of functions.
> - Add a blank line at the top of functions if there are no declarations.

I'd agree that the other changes are following kernel coding style, but
I've never heard of leaving a blank line at the start of functions without
any local variables.  I don't see anything in process/coding-style.rst to
support this change, nor are the majority of variable-less functions
formatted this way, and it seems to just be a waste of vertical space.

Cheers, Andreas

Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)