linux-kernel - Re: [PATCH v2 1/1] Fonts: Replace discarded const qualifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201103095239.GW401619@phenom.ffwll.local>
Date:   Tue, 3 Nov 2020 10:52:39 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Daniel Vetter <daniel.vetter@...ll.ch>,
        Lee Jones <lee.jones@...aro.org>,
        Peilin Ye <yepeilin.cs@...il.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] Fonts: Replace discarded const qualifier

On Tue, Nov 03, 2020 at 10:15:38AM +0100, Greg KH wrote:
> On Tue, Nov 03, 2020 at 09:58:18AM +0100, Daniel Vetter wrote:
> > On Tue, Nov 3, 2020 at 9:53 AM Lee Jones <lee.jones@...aro.org> wrote:
> > >
> > > On Mon, 02 Nov 2020, Peilin Ye wrote:
> > >
> > > > From: Lee Jones <lee.jones@...aro.org>
> > > >
> > > > Commit 6735b4632def ("Fonts: Support FONT_EXTRA_WORDS macros for built-in
> > > > fonts") introduced the following error when building rpc_defconfig (only
> > > > this build appears to be affected):
> > > >
> > > >  `acorndata_8x8' referenced in section `.text' of arch/arm/boot/compressed/ll_char_wr.o:
> > > >     defined in discarded section `.data' of arch/arm/boot/compressed/font.o
> > > >  `acorndata_8x8' referenced in section `.data.rel.ro' of arch/arm/boot/compressed/font.o:
> > > >     defined in discarded section `.data' of arch/arm/boot/compressed/font.o
> > > >  make[3]: *** [/scratch/linux/arch/arm/boot/compressed/Makefile:191: arch/arm/boot/compressed/vmlinux] Error 1
> > > >  make[2]: *** [/scratch/linux/arch/arm/boot/Makefile:61: arch/arm/boot/compressed/vmlinux] Error 2
> > > >  make[1]: *** [/scratch/linux/arch/arm/Makefile:317: zImage] Error 2
> > > >
> > > > The .data section is discarded at link time.  Reinstating acorndata_8x8 as
> > > > const ensures it is still available after linking.  Do the same for the
> > > > other 12 built-in fonts as well, for consistency purposes.
> > > >
> > > > Cc: <stable@...r.kernel.org>
> > > > Cc: Russell King <linux@...linux.org.uk>
> > > > Fixes: 6735b4632def ("Fonts: Support FONT_EXTRA_WORDS macros for built-in fonts")
> > > > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > > > Co-developed-by: Peilin Ye <yepeilin.cs@...il.com>
> > > > Signed-off-by: Peilin Ye <yepeilin.cs@...il.com>
> > > > ---
> > > > Changes in v2:
> > > >   - Fix commit ID to 6735b4632def in commit message (Russell King
> > > >     <linux@...linux.org.uk>)
> > > >   - Add `const` back for all 13 built-in fonts (Daniel Vetter
> > > >     <daniel.vetter@...ll.ch>)
> > > >   - Add a Fixes: tag
> > > >
> > > >  lib/fonts/font_10x18.c     | 2 +-
> > > >  lib/fonts/font_6x10.c      | 2 +-
> > > >  lib/fonts/font_6x11.c      | 2 +-
> > > >  lib/fonts/font_6x8.c       | 2 +-
> > > >  lib/fonts/font_7x14.c      | 2 +-
> > > >  lib/fonts/font_8x16.c      | 2 +-
> > > >  lib/fonts/font_8x8.c       | 2 +-
> > > >  lib/fonts/font_acorn_8x8.c | 2 +-
> > > >  lib/fonts/font_mini_4x6.c  | 2 +-
> > > >  lib/fonts/font_pearl_8x8.c | 2 +-
> > > >  lib/fonts/font_sun12x22.c  | 2 +-
> > > >  lib/fonts/font_sun8x16.c   | 2 +-
> > > >  lib/fonts/font_ter16x32.c  | 2 +-
> > > >  13 files changed, 13 insertions(+), 13 deletions(-)
> > >
> > > LGTM.
> > >
> > > Thanks for keeping my authorship.  Much appreciated.
> > 
> > Should I stuff this into drm-misc-fixes? Or will someone else pick
> > this up? Greg?
> > 
> > I guess drm-misc-fixes might be easiest since there's a bunch of other
> > fbcon/font stuff in the queue in drm-misc from Peilin.
> 
> You can take it:
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Applied to drm-misc-fixes, thanks everyone!

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch