linux-kernel - Re: [PATCH v3 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201103133644.GA2067567@kroah.com>
Date:   Tue, 3 Nov 2020 14:36:44 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Luo Jiaxing <luojiaxing@...wei.com>
Cc:     akpm@...ux-foundation.org, viro@...iv.linux.org.uk,
        andriy.shevchenko@...ux.intel.com, linux-kernel@...r.kernel.org,
        martin.petersen@...cle.com, john.garry@...wei.com,
        himanshu.madhani@...ium.com, felipe.balbi@...ux.intel.com,
        uma.shankar@...el.com, anshuman.gupta@...el.com,
        animesh.manna@...el.com, linux-usb@...r.kernel.org,
        linux-scsi@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH v3 0/5] Introduce a new helper marco
 DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c

On Tue, Nov 03, 2020 at 08:29:39PM +0800, Luo Jiaxing wrote:
> We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
> for read-only file, but we found many of drivers also want a helper macro
> for read-write file too.
> 
> So we add this macro to help decrease code duplication.
> 
> ---
>  v1->v2:
>         1.Rename DEFINE_STORE_ATTRIBUTE() to DEFINE_SHOW_STORE_ATTRIBUTE().
>  v2->v3:
>         1.Fixed some spelling mistakes in commit.
>         2.Revised resumes are added for easy tracing.

You forgot to address Al Viro's review comments :(