linux-kernel - Re: [PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201104190612.GA3959462@bogus>
Date:   Wed, 4 Nov 2020 13:06:12 -0600
From:   Rob Herring <robh@...nel.org>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        linux-kernel@...r.kernel.org, Stefan Wahren <wahrenst@....net>,
        Ray Jui <rjui@...adcom.com>, u.kleine-koenig@...gutronix.de,
        devicetree@...r.kernel.org, Eric Anholt <eric@...olt.net>,
        dmitry.torokhov@...il.com, Rob Herring <robh+dt@...nel.org>,
        bcm-kernel-feedback-list@...adcom.com, p.zabel@...gutronix.de,
        linux-rpi-kernel@...ts.infradead.org, gregkh@...uxfoundation.org,
        linux-input@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-arm-kernel@...ts.infradead.org, linux-pwm@...r.kernel.org,
        bgolaszewski@...libre.com, sboyd@...nel.org,
        linux-gpio@...r.kernel.org, Scott Branden <sbranden@...adcom.com>,
        linus.walleij@...aro.org, linux-clk@...r.kernel.org,
        andy.shevchenko@...il.com
Subject: Re: [PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware
 PWM bus

On Wed, 04 Nov 2020 11:39:35 +0100, Nicolas Saenz Julienne wrote:
> The PWM bus controlling the fan in RPi's official PoE hat can only be
> controlled by the board's co-processor.
> 
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
> Reviewed-by: Rob Herring <robh@...nel.org>
> 
> ---
> 
> Changes since v1:
>  - Update bindings to use 2 #pwm-cells
> 
>  .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 20 +++++++++++++++++++
>  .../pwm/raspberrypi,firmware-pwm.h            | 13 ++++++++++++
>  2 files changed, 33 insertions(+)
>  create mode 100644 include/dt-bindings/pwm/raspberrypi,firmware-pwm.h
> 


My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: pwm:#pwm-cells:0:0: 2 was expected
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml


See https://patchwork.ozlabs.org/patch/1393804

The base for the patch is generally the last rc1. Any dependencies
should be noted.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.