linux-kernel - Re: [RFC PATCH] .clang-format: Remove conditional comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 03 Nov 2020 20:16:59 -0800
From:   Joe Perches <joe@...ches.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     clang-built-linux <clang-built-linux@...glegroups.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] .clang-format: Remove conditional comments

On Wed, 2020-11-04 at 04:57 +0100, Miguel Ojeda wrote:
> On Wed, Nov 4, 2020 at 4:15 AM Joe Perches <joe@...ches.com> wrote:
> > 
> > No one ever will use clang-format on the current kernel sources
> > without having a recent version of clang and clang-format.
> 
> Why? Many distros come with clang-format pre-packaged, and in fact the
> original patch (that you commented on) argued for the >= 4 requirement
> that way.

The current kernel is v5.10 which requires clang 10.0 or higher.
This patch is for the current kernel.

This patch is not to be applied or backported to old kernels so no
person is going to use this patch on any old or backported kernel.

If a person is going to use clang-format on the current kernel sources
unless they are developing for the current kernel.

They are going to have to be using clang 10.0 or higher and therefore
also will have and be using clang-format 10.0 or higher.

Take it or not, apply it or not.  I don't use clang-format and unless
there are improvements to it, I imagine I'll continue to use emacs
indent-region and a few other reformatting tools instead.

cheers, Joe