linux-kernel - Re: [PATCH] clk: ingenic/TCU: Remove NULL pointer check before clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <ECR9JQ.NFV4ZB9VUP182@crapouillou.net>
Date:   Wed, 04 Nov 2020 11:17:02 +0000
From:   Paul Cercueil <paul@...pouillou.net>
To:     Xu Wang <vulab@...as.ac.cn>
Cc:     mturquette@...libre.com, sboyd@...nel.org,
        linux-clk@...r.kernel.or, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: ingenic/TCU: Remove NULL pointer check before
 clk_enable/disable

Hi,

Le mer. 4 nov. 2020 à 7:11, Xu Wang <vulab@...as.ac.cn> a écrit :
> Because clk_enable and clk_disable already checked NULL clock 
> parameter,
> so the additional checks are unnecessary, just remove them.
> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>

Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> ---
>  drivers/clk/ingenic/tcu.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/ingenic/tcu.c b/drivers/clk/ingenic/tcu.c
> index 9382dc3aa27e..ffcb3667fd2b 100644
> --- a/drivers/clk/ingenic/tcu.c
> +++ b/drivers/clk/ingenic/tcu.c
> @@ -445,8 +445,7 @@ static int __maybe_unused tcu_pm_suspend(void)
>  {
>  	struct ingenic_tcu *tcu = ingenic_tcu;
> 
> -	if (tcu->clk)
> -		clk_disable(tcu->clk);
> +	clk_disable(tcu->clk);
> 
>  	return 0;
>  }
> @@ -455,8 +454,7 @@ static void __maybe_unused tcu_pm_resume(void)
>  {
>  	struct ingenic_tcu *tcu = ingenic_tcu;
> 
> -	if (tcu->clk)
> -		clk_enable(tcu->clk);
> +	clk_enable(tcu->clk);
>  }
> 
>  static struct syscore_ops __maybe_unused tcu_pm_ops = {
> --
> 2.17.1
>