[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20201104164126.36399-1-fazilyildiran@gmail.com>
Date: Wed, 4 Nov 2020 19:41:27 +0300
From: Necip Fazil Yildiran <fazilyildiran@...il.com>
To: hauke@...ke-m.de
Cc: szajec5@...il.com, linux-mips@...r.kernel.org,
linux-kernel@...r.kernel.org, paul@...zz.com, jeho@...utexas.edu,
Necip Fazil Yildiran <fazilyildiran@...il.com>
Subject: [PATCH] MIPS: BMC47xx: fix kconfig dependency bug for BCM47XX_SSB
When BCM47XX_SSB is enabled and SSB_PCIHOST is disabled, it results in the
following Kbuild warning:
WARNING: unmet direct dependencies detected for SSB_B43_PCI_BRIDGE
Depends on [n]: SSB [=y] && SSB_PCIHOST [=n]
Selected by [y]:
- BCM47XX_SSB [=y] && BCM47XX [=y] && PCI [=y]
The reason is that BCM47XX_SSB selects SSB_B43_PCI_BRIDGE without
depending on or selecting SSB_PCIHOST while SSB_B43_PCI_BRIDGE depends on
SSB_PCIHOST. This can also fail building the kernel as demonstrated in a
bug report.
Honor the kconfig dependency to remove unmet direct dependency warnings
and avoid any potential build failures.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=210051
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>
---
arch/mips/bcm47xx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig
index 6889f74e06f5..40876654423c 100644
--- a/arch/mips/bcm47xx/Kconfig
+++ b/arch/mips/bcm47xx/Kconfig
@@ -9,6 +9,7 @@ config BCM47XX_SSB
select SSB_DRIVER_MIPS
select SSB_DRIVER_EXTIF
select SSB_EMBEDDED
+ select SSB_PCIHOST if PCI
select SSB_B43_PCI_BRIDGE if PCI
select SSB_DRIVER_PCICORE if PCI
select SSB_PCICORE_HOSTMODE if PCI
--
2.25.1
Powered by blists - more mailing lists