linux-kernel - Re: [PATCH] MIPS: BMC47xx: fix kconfig dependency bug for BCM47XX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <547e42cd-f39b-1128-4836-82891dd770d1@gmail.com>
Date:   Fri, 6 Nov 2020 11:24:41 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Necip Fazil Yildiran <fazilyildiran@...il.com>, hauke@...ke-m.de
Cc:     szajec5@...il.com, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, paul@...zz.com, jeho@...utexas.edu
Subject: Re: [PATCH] MIPS: BMC47xx: fix kconfig dependency bug for BCM47XX_SSB

Hello!

On 04.11.2020 19:41, Necip Fazil Yildiran wrote:

> When BCM47XX_SSB is enabled and SSB_PCIHOST is disabled, it results in the
> following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for SSB_B43_PCI_BRIDGE
>    Depends on [n]: SSB [=y] && SSB_PCIHOST [=n]
>    Selected by [y]:
>    - BCM47XX_SSB [=y] && BCM47XX [=y] && PCI [=y]
> 
> The reason is that BCM47XX_SSB selects SSB_B43_PCI_BRIDGE without
> depending on or selecting SSB_PCIHOST while SSB_B43_PCI_BRIDGE depends on
> SSB_PCIHOST. This can also fail building the kernel as demonstrated in a
> bug report.
> 
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=210051

    Isn't that tag supposed to be used for the patch mail itself? At least
that's what I'm seeing in the USB patches where it points to the msg with
a patch...

> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>
[...]

MBR, Sergei