linux-kernel - Re: [PATCH] MIPS: BMC47xx: fix kconfig dependency bug for BCM47XX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201112223839.GB19695@alpha.franken.de>
Date:   Thu, 12 Nov 2020 23:38:39 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Necip Fazil Yildiran <fazilyildiran@...il.com>
Cc:     hauke@...ke-m.de, szajec5@...il.com, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, paul@...zz.com, jeho@...utexas.edu
Subject: Re: [PATCH] MIPS: BMC47xx: fix kconfig dependency bug for BCM47XX_SSB

On Wed, Nov 04, 2020 at 07:41:27PM +0300, Necip Fazil Yildiran wrote:
> When BCM47XX_SSB is enabled and SSB_PCIHOST is disabled, it results in the
> following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for SSB_B43_PCI_BRIDGE
>   Depends on [n]: SSB [=y] && SSB_PCIHOST [=n]
>   Selected by [y]:
>   - BCM47XX_SSB [=y] && BCM47XX [=y] && PCI [=y]
> 
> The reason is that BCM47XX_SSB selects SSB_B43_PCI_BRIDGE without
> depending on or selecting SSB_PCIHOST while SSB_B43_PCI_BRIDGE depends on
> SSB_PCIHOST. This can also fail building the kernel as demonstrated in a
> bug report.
> 
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=210051
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>
> ---
>  arch/mips/bcm47xx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]