linux-kernel - Re: Kunit fixes update for Linux 5.10-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wiscEwD+a4M2mns1kf2S+yE6gcPp0sn4znVt0ZUxaP3Wg@mail.gmail.com>
Date:   Thu, 5 Nov 2020 12:02:41 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     Brendan Higgins <brendanhiggins@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>
Subject: Re: Kunit fixes update for Linux 5.10-rc3

On Thu, Nov 5, 2020 at 8:55 AM Shuah Khan <skhan@...uxfoundation.org> wrote:
>
>   .../kunit/test_data/test_config_printk_time.log    | Bin 1584 -> 1605 bytes
>   .../test_data/test_interrupted_tap_output.log      | Bin 1982 -> 2003 bytes
>   .../test_data/test_kernel_panic_interrupt.log      | Bin 1321 -> 1342 bytes
>   .../kunit/test_data/test_multiple_prefixes.log     | Bin 1832 -> 1861

This diffstat is a bit annoying.

And the reason is that we have

    [torvalds@...en linux]$ cat tools/testing/kunit/.gitattributes
    test_data/* binary

iow, you're telling git that everything in that test_data directory is
binary blobs. Which isn't actually true.

This isn't new, but it was just more noticeable this time around.

That binary marker comes from commit afc63da64f1e ("kunit:
kunit_parser: make parser more robust") and I'm not really seeing the
reason for it.

                 Linus