[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJht_EPP_otbU226Ub5mC_OZPXO4h0O2-URkpsrMBFovcdDHWQ@mail.gmail.com>
Date: Thu, 5 Nov 2020 12:04:55 -0800
From: Xie He <xie.he.0141@...il.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Jakub Kicinski <kuba@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Networking <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Arnd Bergmann <arnd@...db.de>, Martin Schiller <ms@....tdt.de>,
Andrew Hendry <andrew.hendry@...il.com>,
Linux X25 <linux-x25@...r.kernel.org>
Subject: Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver
On Thu, Nov 5, 2020 at 7:07 AM Arnd Bergmann <arnd@...nel.org> wrote:
>
> Adding Martin Schiller and Andrew Hendry, plus the linux-x25 mailing
> list to Cc.
The linux-x25 mail list has stopped working for a long time.
> When I last looked at the wan drivers, I think I concluded
> that this should still be kept around, but I do not remember why.
I think we only decided that X.25 as a whole was still needed. We
didn't decide that this particular driver was necessary.
> Since you did the bugfix mentioned above, do you have an idea
> when it could have last worked? I see it was originally merged in
> linux-2.3.21, and Stephen Hemminger did a cleanup for
> linux-2.6.0-rc3 that he apparently tested but also said "Not sure
> if anyone ever uses this.".
I think this driver never worked. Looking at the original code in
Linux 2.1.31, it already has the problems I fixed in commit
8fdcabeac398.
I guess when people (or bots) say they "tested", they have not
necessarily used this driver to actually try transporting data. They
may just have tested open/close, etc. to confirm that the particular
problem/issue they saw had been fixed.
Powered by blists - more mailing lists