linux-kernel - Re: [PATCH v2 1/8] clk: at91: sama7g5: fix compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c3c2191-d01d-2254-32b4-1873ebb1b78d@microchip.com>
Date:   Thu, 5 Nov 2020 08:55:00 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <Claudiu.Beznea@...rochip.com>, <mturquette@...libre.com>,
        <sboyd@...nel.org>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Ludovic.Desroches@...rochip.com>,
        <robh+dt@...nel.org>
CC:     <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <Eugen.Hristev@...rochip.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/8] clk: at91: sama7g5: fix compilation error

On 11/4/20 7:45 PM, Claudiu Beznea wrote:
> pmc_data_allocate() has been changed. pmc_data_free() was removed.
> Adapt the code taking this into consideration. With this the programmable
> clocks were also saved in sama7g5_pmc so that they could be later
> referenced.
> 
> Fixes: cb783bbbcf54 ("clk: at91: sama7g5: add clock support for sama7g5")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@...rochip.com>
Tested-by: Tudor Ambarus <tudor.ambarus@...rochip.com>

> ---
>  drivers/clk/at91/sama7g5.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/at91/sama7g5.c b/drivers/clk/at91/sama7g5.c
> index 0db2ab3eca14..a092a940baa4 100644
> --- a/drivers/clk/at91/sama7g5.c
> +++ b/drivers/clk/at91/sama7g5.c
> @@ -838,7 +838,7 @@ static void __init sama7g5_pmc_setup(struct device_node *np)
>  	sama7g5_pmc = pmc_data_allocate(PMC_I2S1_MUX + 1,
>  					nck(sama7g5_systemck),
>  					nck(sama7g5_periphck),
> -					nck(sama7g5_gck));
> +					nck(sama7g5_gck), 8);
>  	if (!sama7g5_pmc)
>  		return;
>  
> @@ -980,6 +980,8 @@ static void __init sama7g5_pmc_setup(struct device_node *np)
>  						    sama7g5_prog_mux_table);
>  		if (IS_ERR(hw))
>  			goto err_free;
> +
> +		sama7g5_pmc->pchws[i] = hw;
>  	}
>  
>  	for (i = 0; i < ARRAY_SIZE(sama7g5_systemck); i++) {
> @@ -1052,7 +1054,7 @@ static void __init sama7g5_pmc_setup(struct device_node *np)
>  		kfree(alloc_mem);
>  	}
>  
> -	pmc_data_free(sama7g5_pmc);
> +	kfree(sama7g5_pmc);
>  }
>  
>  /* Some clks are used for a clocksource */
>