linux-kernel - Re: [PATCH 4/6] arm64: dts: allwinner: pinephone: Add light/proximity sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201105112319.ic2gpb7bbsqn2ueh@gilmour.lan>
Date:   Thu, 5 Nov 2020 12:23:19 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        linux-arm-kernel@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com,
        Ondrej Jirman <megous@...ous.com>
Subject: Re: [PATCH 4/6] arm64: dts: allwinner: pinephone: Add
 light/proximity sensor

Hi,

On Wed, Nov 04, 2020 at 11:41:33PM -0600, Samuel Holland wrote:
> From: Ondrej Jirman <megous@...ous.com>
> 
> Pinephone has STK3311-X proximity sensor. Add support for it.
> 
> Signed-off-by: Ondrej Jirman <megous@...ous.com>
> Signed-off-by: Samuel Holland <samuel@...lland.org>
> ---
>  .../arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> index e595a8262920..9544d7658794 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> @@ -160,6 +160,16 @@ lis3mdl: lis3mdl@1e {
>  		vddio-supply = <&reg_dldo1>;
>  	};
>  
> +	/* Light/proximity sensor */
> +	stk3311@48 {
> +		compatible = "sensortek,stk3311";
> +		reg = <0x48>;
> +		interrupt-parent = <&pio>;
> +		interrupts = <1 0 IRQ_TYPE_EDGE_FALLING>; /* PB0 */
> +		vdd-supply = <&reg_ldo_io0>;
> +		leda-supply = <&reg_dldo1>;
> +	};
> +

The node names should be the class of the device, not the model. The
other sensors here have a similar issue though, so I've applied it, but
could you send a subsequent patch fixing this?

Thanks!
Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)