linux-kernel - Re: [PATCH 5/6] arm64: dts: allwinner: pinephone: Add WiFi support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Nov 2020 12:24:08 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        linux-arm-kernel@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com,
        Ondrej Jirman <megous@...ous.com>
Subject: Re: [PATCH 5/6] arm64: dts: allwinner: pinephone: Add WiFi support

On Wed, Nov 04, 2020 at 11:41:34PM -0600, Samuel Holland wrote:
> From: Ondrej Jirman <megous@...ous.com>
> 
> The PinePhone has a Realtek rtl8723cs WiFi module.
> 
> On mainboard revisions 1.0 and 1.1, the reset input is always pulled
> high, so no power sequence is needed. On mainboard revision 1.2, the
> reset input is connected to PL2.
> 
> Signed-off-by: Ondrej Jirman <megous@...ous.com>
> Signed-off-by: Samuel Holland <samuel@...lland.org>
> ---
>  .../allwinner/sun50i-a64-pinephone-1.2.dts    |  9 ++++++++
>  .../dts/allwinner/sun50i-a64-pinephone.dtsi   | 22 +++++++++++++++++++
>  2 files changed, 31 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
> index 94e4f11e0215..e7cf9d8577c1 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
> @@ -8,6 +8,11 @@
>  / {
>  	model = "Pine64 PinePhone (1.2)";
>  	compatible = "pine64,pinephone-1.2", "allwinner,sun50i-a64";
> +
> +	wifi_pwrseq: wifi_pwrseq {
> +		compatible = "mmc-pwrseq-simple";
> +		reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
> +	};

Underscores are not valid in node names. I've fixed it while applying

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)