linux-kernel - Re: [PATCH 4.19 107/191] ARM: dts: s5pv210: move PMU node out of clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Nov 2020 21:12:45 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Pavel Machek <pavel@....cz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Jonathan Bakker <xc-racer2@...e.ca>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 107/191] ARM: dts: s5pv210: move PMU node out of
 clock controller

On Thu, Nov 05, 2020 at 08:55:08PM +0100, Pavel Machek wrote:
> Hi!
> 
> > > > The Power Management Unit (PMU) is a separate device which has little
> > > > common with clock controller.  Moving it to one level up (from clock
> > > > controller child to SoC) allows to remove fake simple-bus compatible and
> > > > dtbs_check warnings like:
> > > >
> > > >   clock-controller@...00000: $nodename:0:
> > > >     'clock-controller@...00000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
> > >
> > > > +++ b/arch/arm/boot/dts/s5pv210.dtsi
> > > > @@ -98,19 +98,16 @@
> > > >               };
> > > >
> > > >               clocks: clock-controller@...00000 {
> > > > -                     compatible = "samsung,s5pv210-clock", "simple-bus";
> > > > +                     compatible = "samsung,s5pv210-clock";
> > > >                       reg = <0xe0100000 0x10000>;
> > > ...
> > > > +             pmu_syscon: syscon@...08000 {
> > > > +                     compatible = "samsung-s5pv210-pmu", "syscon";
> > > > +                     reg = <0xe0108000 0x8000>;
> > > >               };
> > >
> > > Should clock-controller@...00000's reg be shortened to 0x8000 so that
> > > the ranges do not overlap?
> > >
> > > Signed-off-by: Pavel Machek (CIP) <pavel@...x.de>
> > 
> > I don't think this commit should be backported to stable. It is simple
> > dtbs_check - checking whether Devicetree source matches device tree
> > schema. Neither the schema nor the warning existed in v4.19. I think
> > dtbs_check fixes should not be backported, unless a real issue is
> > pointed out.
> 
> I agree with you about the backporting. Hopefully Greg drops the
> commit.
> 
> But the other issue is: should mainline be fixed so that ranges do not overlap?

Yes, it should be. This should fail on mapping resources...

I'll take a look, thanks for the report.

Best regards,
Krzysztof