linux-kernel - Re: [PATCH net] net: marvell: prestera: fix compilation with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d67e1d4-4f5c-a0c1-ce87-42e141215aa1@infradead.org>
Date:   Fri, 6 Nov 2020 12:13:12 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Vadym Kochan <vadym.kochan@...ision.eu>,
        Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>,
        Andrii Savka <andrii.savka@...ision.eu>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        Serhiy Boiko <serhiy.boiko@...ision.eu>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Mickey Rachamim <mickeyr@...vell.com>
Subject: Re: [PATCH net] net: marvell: prestera: fix compilation with
 CONFIG_BRIDGE=m

On 11/6/20 8:11 AM, Vadym Kochan wrote:
> With CONFIG_BRIDGE=m the compilation fails:
> 
>     ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function `prestera_bridge_port_event':
>     prestera_switchdev.c:(.text+0x2ebd): undefined reference to `br_vlan_enabled'
> 
> in case the driver is statically enabled.
> 
> Fix it by adding 'BRIDGE || BRIDGE=n' dependency.
> 
> Fixes: e1189d9a5fbe ("net: marvell: prestera: Add Switchdev driver implementation")
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Vadym Kochan <vadym.kochan@...ision.eu>


Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> ---
>  drivers/net/ethernet/marvell/prestera/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/marvell/prestera/Kconfig b/drivers/net/ethernet/marvell/prestera/Kconfig
> index b1fcc44f566a..b6f20e2034c6 100644
> --- a/drivers/net/ethernet/marvell/prestera/Kconfig
> +++ b/drivers/net/ethernet/marvell/prestera/Kconfig
> @@ -6,6 +6,7 @@
>  config PRESTERA
>  	tristate "Marvell Prestera Switch ASICs support"
>  	depends on NET_SWITCHDEV && VLAN_8021Q
> +	depends on BRIDGE || BRIDGE=n
>  	select NET_DEVLINK
>  	help
>  	  This driver supports Marvell Prestera Switch ASICs family.
> 


-- 
~Randy