[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <160464840151.97255.15344214064240834294.sendpatchset@MacBook-Pro.local>
Date: Fri, 06 Nov 2020 13:10:06 +0530
From: Sachin Sant <sachinp@...ux.vnet.ibm.com>
To: Michael Ellerman <michael@...erman.id.au>,
linux-kselftest@...r.kernel.org, skhan@...uxfoundation.org
Cc: Sachin Sant <sachinp@...ux.vnet.ibm.com>, christian@...uner.io,
linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
keescook@...omium.org
Subject: [PATCH V2] selftests/cgroup: Fix build on older distros
On older distros struct clone_args does not have a cgroup member,
leading to build errors:
cgroup_util.c: In function 'clone_into_cgroup':
cgroup_util.c:343:4: error: 'struct clone_args' has no member named 'cgroup'
cgroup_util.c:346:33: error: invalid application of 'sizeof' to incomplete
type 'struct clone_args'
But the selftests already have a locally defined version of the
structure which is up to date, called __clone_args.
So use __clone_args which fixes the error.
Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
Signed-off-by: Sachin Sant <sachinp@...ux.vnet.ibm.com>>
Acked-by: Christian Brauner <christian.brauner@...ntu.com>
---
V2: Replace all instances of clone_args by __clone_args
---
diff --git a/a/tools/testing/selftests/cgroup/cgroup_util.c b/b/tools/testing/selftests/cgroup/cgroup_util.c
index 05853b0..0270146 100644
--- a/a/tools/testing/selftests/cgroup/cgroup_util.c
+++ b/b/tools/testing/selftests/cgroup/cgroup_util.c
@@ -337,13 +337,13 @@ pid_t clone_into_cgroup(int cgroup_fd)
#ifdef CLONE_ARGS_SIZE_VER2
pid_t pid;
- struct clone_args args = {
+ struct __clone_args args = {
.flags = CLONE_INTO_CGROUP,
.exit_signal = SIGCHLD,
.cgroup = cgroup_fd,
};
- pid = sys_clone3(&args, sizeof(struct clone_args));
+ pid = sys_clone3(&args, sizeof(struct __clone_args));
/*
* Verify that this is a genuine test failure:
* ENOSYS -> clone3() not available
Powered by blists - more mailing lists