linux-kernel - Re: [PATCH 1/1] x86/mce: remove unused WARN_ON() in mce_register_decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Nov 2020 21:20:38 +0800
From:   "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>
To:     Borislav Petkov <bp@...en8.de>
CC:     Tony Luck <tony.luck@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, x86 <x86@...nel.org>,
        "H . Peter Anvin" <hpa@...or.com>,
        linux-edac <linux-edac@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] x86/mce: remove unused WARN_ON() in
 mce_register_decode_chain()



On 2020/11/6 19:12, Borislav Petkov wrote:
> On Fri, Nov 06, 2020 at 04:43:40PM +0800, Zhen Lei wrote:
>> enum mce_notifier_prios {
>>         MCE_PRIO_LOWEST,
>>         MCE_PRIO_MCELOG,
>>         MCE_PRIO_EDAC,
>>
>> After commit c9c6d216ed28 ("x86/mce: Rename "first" function as "early""),
>> there is no other integer between MCE_PRIO_MCELOG and MCE_PRIO_EDAC.
>> Therefore, the WARN_ON() will never be triggered, just delete it.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
>> ---
>>  arch/x86/kernel/cpu/mce/core.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
>> index 4102b866e7c0..914f9f102995 100644
>> --- a/arch/x86/kernel/cpu/mce/core.c
>> +++ b/arch/x86/kernel/cpu/mce/core.c
>> @@ -162,9 +162,6 @@ EXPORT_SYMBOL_GPL(mce_log);
>>  
>>  void mce_register_decode_chain(struct notifier_block *nb)
>>  {
>> -	if (WARN_ON(nb->priority > MCE_PRIO_MCELOG && nb->priority < MCE_PRIO_EDAC))
>> -		return;
> 
> No, you don't want to remove it - you want to update it so that it
> catches wrong priorities...

Oh, Yes, You're right. I will send v2.


> 
> Thx.
>