linux-kernel - Re: [PATCH] x86/platform/uv: drop last traces of uv_flush_tlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5847a155-cb70-7795-235b-746a57f2dac2@hpe.com>
Date:   Mon, 9 Nov 2020 07:07:23 -0800
From:   Mike Travis <mike.travis@....com>
To:     Jiri Slaby <jslaby@...e.cz>, bp@...en8.de
Cc:     linux-kernel@...r.kernel.org,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Steve Wahl <steve.wahl@....com>,
        Russ Anderson <russ.anderson@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86/platform/uv: drop last traces of uv_flush_tlb_others

Thanks Jiri for catching that.

Acked-By: Mike Travis <mike.travis@....com>

On 11/9/2020 1:36 AM, Jiri Slaby wrote:
> Commit 39297dde7390 ("x86/platform/uv: Remove UV BAU TLB Shootdown
> Handler") removed uv_flush_tlb_others. Its declaration was removed also
> from asm/uv/uv.h. But only for the CONFIG_X86_UV=y case. The inline
> definition (!X86_UV case) is still in place.
> 
> So remove this implementation with everything what was added to support
> uv_flush_tlb_others:
> * include of asm/tlbflush.h
> * forward declarations of struct cpumask, mm_struct, and flush_tlb_info
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Mike Travis <mike.travis@....com>
> Cc: Dimitri Sivanich <dimitri.sivanich@....com>
> Cc: Steve Wahl <steve.wahl@....com>
> Cc: Russ Anderson <russ.anderson@....com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: x86@...nel.org
> Cc: "H. Peter Anvin" <hpa@...or.com>
> ---
>   arch/x86/include/asm/uv/uv.h | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
> index 172d3e4a9e4b..648eb23fe7f0 100644
> --- a/arch/x86/include/asm/uv/uv.h
> +++ b/arch/x86/include/asm/uv/uv.h
> @@ -2,14 +2,8 @@
>   #ifndef _ASM_X86_UV_UV_H
>   #define _ASM_X86_UV_UV_H
>   
> -#include <asm/tlbflush.h>
> -
>   enum uv_system_type {UV_NONE, UV_LEGACY_APIC, UV_X2APIC};
>   
> -struct cpumask;
> -struct mm_struct;
> -struct flush_tlb_info;
> -
>   #ifdef CONFIG_X86_UV
>   #include <linux/efi.h>
>   
> @@ -44,10 +38,6 @@ static inline int is_uv_system(void)	{ return 0; }
>   static inline int is_uv_hubbed(int uv)	{ return 0; }
>   static inline void uv_cpu_init(void)	{ }
>   static inline void uv_system_init(void)	{ }
> -static inline const struct cpumask *
> -uv_flush_tlb_others(const struct cpumask *cpumask,
> -		    const struct flush_tlb_info *info)
> -{ return cpumask; }
>   
>   #endif	/* X86_UV */
>   
>