linux-kernel - RE: [RFC PATCH v3.1 03/27] mmc: core: UHS-II support, skip set_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Nov 2020 07:15:18 +0000
From:   Bough Chen <haibo.chen@....com>
To:     AKASHI Takahiro <takahiro.akashi@...aro.org>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ben.chuang@...esyslogic.com.tw" <ben.chuang@...esyslogic.com.tw>,
        "greg.tu@...esyslogic.com.tw" <greg.tu@...esyslogic.com.tw>
Subject: RE: [RFC PATCH v3.1 03/27] mmc: core: UHS-II support, skip
 set_chip_select()

> -----Original Message-----
> From: AKASHI Takahiro [mailto:takahiro.akashi@...aro.org]
> Sent: 2020年11月6日 10:27
> To: ulf.hansson@...aro.org; adrian.hunter@...el.com
> Cc: linux-mmc@...r.kernel.org; linux-kernel@...r.kernel.org;
> ben.chuang@...esyslogic.com.tw; greg.tu@...esyslogic.com.tw; AKASHI
> Takahiro <takahiro.akashi@...aro.org>
> Subject: [RFC PATCH v3.1 03/27] mmc: core: UHS-II support, skip
> set_chip_select()
> 
> mmc_set_chip_select() should be called only in UHS-II mode, and not for UHS-II
> mode.

Typo, only in UHS-I mode.

Regards
Haibo Chen
> 
> Signed-off-by: Ben Chuang <ben.chuang@...esyslogic.com.tw>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@...aro.org>
> ---
>  drivers/mmc/core/core.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index
> 5541ed956c4d..4e12bd98fc08 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -898,8 +898,10 @@ static inline void mmc_set_ios(struct mmc_host
> *host)
>   */
>  void mmc_set_chip_select(struct mmc_host *host, int mode)  {
> -	host->ios.chip_select = mode;
> -	mmc_set_ios(host);
> +	if (!(host->flags & MMC_UHS2_INITIALIZED)) {
> +		host->ios.chip_select = mode;
> +		mmc_set_ios(host);
> +	}
>  }
> 
>  /*
> --
> 2.28.0