linux-kernel - Re: [f2fs-dev] [PATCH v4 2/2] f2fs: fix compat F2FS_IOC_{MOVE, GARBAGE_COLLECT}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5ce8331-3297-7e38-42a0-0a6c73c30ff2@huawei.com>
Date:   Tue, 10 Nov 2020 09:54:07 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Eric Biggers <ebiggers@...nel.org>
CC:     Chao Yu <chao@...nel.org>, <jaegeuk@...nel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH v4 2/2] f2fs: fix compat F2FS_IOC_{MOVE,
 GARBAGE_COLLECT}_RANGE

On 2020/11/10 2:12, Eric Biggers wrote:
> On Mon, Nov 09, 2020 at 10:29:25AM +0800, Chao Yu wrote:
>>> Oh I see, the cp-related checks are at the beginning of f2fs_ioctl() too.
>>>
>>> In that case a much better approach would be to add __f2fs_ioctl() which is
>>> called by f2fs_ioctl() and f2fs_compat_ioctl(), and have f2fs_ioctl() and
>>> f2fs_compat_ioctl() do the cp-related checks but not __f2fs_ioctl().
>>
>> Will this cleanup make sense to you?
> 
> I think it would be better to do it the way I suggested.

Updated in v5.

Thanks,

> 
> - Eric
> .
>