[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 11 Nov 2020 18:50:31 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: corbet@....net, keescook@...omium.org, gregkh@...uxfoundation.org,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/13] seqnum_ops: Introduce Sequence Number Ops
On Wed, Nov 11, 2020 at 10:34:05AM -0700, Shuah Khan wrote:
> Not sure what to make of the 6080 atomic_read()s and 3413
> atomic_inc()s, some of which might be assuming uniqueness
> guarantee.
Well, clearly you just did: git grep atimic_{read,inc}() | wc -l and
didn't look at the usage. Equally clearly there can be bugs. Also
evidently much of those are not in fact sequence numbers.
All I'm saying is that if you want a sequence number, inc_return (or
fetch_inc) is the only sane option.
Powered by blists - more mailing lists