linux-kernel - Re: [PATCH v8 2/3] pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 12:53:35 +0100
From:   Lars Povlsen <lars.povlsen@...rochip.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Lars Povlsen <lars.povlsen@...rochip.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        devicetree <devicetree@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-arm Mailing List" <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>
Subject: Re: [PATCH v8 2/3] pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO


Andy Shevchenko writes:

> On Wed, Nov 11, 2020 at 10:52 AM Lars Povlsen
> <lars.povlsen@...rochip.com> wrote:
>> Andy Shevchenko writes:
>> > On Tue, Nov 10, 2020 at 5:51 PM Lars Povlsen <lars.povlsen@...rochip.com> wrote:
>> >> > On Mon, Nov 9, 2020 at 3:27 PM Lars Povlsen <lars.povlsen@...rochip.com> wrote:
>
> ...
>
>> >> >> +               return -EOPNOTSUPP;
>> >> >
>> >> > Are you sure? IIRC internally we are using ENOTSUPP.
>> >> >
>> >> > Couple of drivers seem to be wrongly using the other one.
>> >>
>> >> Checkpatch complains about ENOTSUPP:
>> >>
>> >> # ENOTSUPP is not a standard error code and should be avoided in new patches.
>> >> # Folks usually mean EOPNOTSUPP (also called ENOTSUP), when they type ENOTSUPP.
>> >
>> > checkpatch is wrong if this is internal code and to me sounds like
>> > it's not going out of the kernel.
>> >
>> > ...
>>
>> As it appears there are different opinions on this I'll let the pinctrl
>> maintainer decide.
>
> There are no other opinions.
> Read description of struct pinconf_ops and fix the code.
> checkpatch is simply wrong here.

Lets no start a war :-) - I'll change it...

>
>> >> >> +                       err = -EOPNOTSUPP;
>> >> >
>> >> > Ditto.
>> >>
>> >> Ditto.
>> >
>> > Ditto.

Cheers,

---Lars

-- 
Lars Povlsen,
Microchip