linux-kernel - Re: [PATCH 1/3 v5] ftrace: Have the callbacks receive a struct ftrace_regs instead of pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201112122106.50a3e3c3@gandalf.local.home>
Date:   Thu, 12 Nov 2020 12:21:06 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Miroslav Benes <mbenes@...e.cz>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/3 v5] ftrace: Have the callbacks receive a struct
 ftrace_regs instead of pt_regs

On Thu, 12 Nov 2020 22:38:53 +0530
"Naveen N. Rao" <naveen.n.rao@...ux.ibm.com> wrote:

> > diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h
> > index 629abaf25681..be73350955e4 100644
> > --- a/include/linux/kprobes.h
> > +++ b/include/linux/kprobes.h
> > @@ -345,7 +345,7 @@ static inline void wait_for_kprobe_optimizer(void) 
> > { }
> >  #endif /* CONFIG_OPTPROBES */
> >  #ifdef CONFIG_KPROBES_ON_FTRACE
> >  extern void kprobe_ftrace_handler(unsigned long ip, unsigned long parent_ip,
> > -				  struct ftrace_ops *ops, struct pt_regs *regs);
> > +				  struct ftrace_ops *ops, struct ftrace_regs *fregs);  
> 
> This breaks the build on non-x86 architectures that support 
> KPROBES_ON_FTRACE.

I thought I ran this on my cross tests build. :-/

But it seems this only updated x86. I thought I updated all the other
archs, but it appears that I didn't. I think I may have forgotten to do a
git commit properly.

Let me go and fix that (I have to update this series anyway).

Thanks for reporting.

-- Steve