linux-kernel - RE: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function attribute 'addr'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VE1PR04MB66877659A67152AE02CF443F8FE70@VE1PR04MB6687.eurprd04.prod.outlook.com>
Date:   Thu, 12 Nov 2020 23:12:47 +0000
From:   Leo Li <leoyang.li@....com>
To:     Lee Jones <lee.jones@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Qiang Zhao <qiang.zhao@....com>,
        Scott Wood <scottwood@...escale.com>, act <dmalek@....net>,
        Dan Malek <dan@...eddedalley.com>,
        "Software, Inc" <source@...sta.com>,
        Vitaly Bordug <vbordug@...mvista.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: RE: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function
 attribute 'addr'



> -----Original Message-----
> From: Lee Jones <lee.jones@...aro.org>
> Sent: Thursday, November 12, 2020 4:33 AM
> To: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> Qiang Zhao <qiang.zhao@....com>; Leo Li <leoyang.li@....com>; Scott
> Wood <scottwood@...escale.com>; act <dmalek@....net>; Dan Malek
> <dan@...eddedalley.com>; Software, Inc <source@...sta.com>; Vitaly
> Bordug <vbordug@...mvista.com>; linuxppc-dev@...ts.ozlabs.org
> Subject: Re: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function
> attribute 'addr'
> 
> On Tue, 03 Nov 2020, Lee Jones wrote:
> 
> > Fixes the following W=1 kernel build warning(s):
> >
> >  drivers/soc/fsl/qe/qe_common.c:237: warning: Function parameter or
> member 'addr' not described in 'cpm_muram_dma'
> >  drivers/soc/fsl/qe/qe_common.c:237: warning: Excess function parameter
> 'offset' description in 'cpm_muram_dma'
> >
> > Cc: Qiang Zhao <qiang.zhao@....com>
> > Cc: Li Yang <leoyang.li@....com>
> > Cc: Scott Wood <scottwood@...escale.com>
> > Cc: act <dmalek@....net>
> > Cc: Dan Malek <dan@...eddedalley.com>
> > Cc: "Software, Inc" <source@...sta.com>
> > Cc: Vitaly Bordug <vbordug@...mvista.com>
> > Cc: linuxppc-dev@...ts.ozlabs.org
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > ---
> >  drivers/soc/fsl/qe/qe_common.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/fsl/qe/qe_common.c
> > b/drivers/soc/fsl/qe/qe_common.c index 75075591f6308..497a7e0fd0272
> > 100644
> > --- a/drivers/soc/fsl/qe/qe_common.c
> > +++ b/drivers/soc/fsl/qe/qe_common.c
> > @@ -231,7 +231,7 @@ EXPORT_SYMBOL(cpm_muram_offset);
> >
> >  /**
> >   * cpm_muram_dma - turn a muram virtual address into a DMA address
> > - * @offset: virtual address from cpm_muram_addr() to convert
> > + * @addr: virtual address from cpm_muram_addr() to convert
> >   */
> >  dma_addr_t cpm_muram_dma(void __iomem *addr)  {
> 
> Any idea who will pick this up?

I can pick them up through my tree, but I haven't created the for-next branch for the next kernel yet.  Will look through this series soon.  Thanks.

> 
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services Linaro.org │ Open source
> software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog