linux-kernel - Re: [PATCH V2 4/5] arm64: dts: ti: k3-am654-base-board: Fix up un-necessary status set to "okay" for USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff878520-4939-0f51-dabf-7f7b5ff54311@ti.com>
Date:   Thu, 12 Nov 2020 15:01:45 +0200
From:   Roger Quadros <rogerq@...com>
To:     Nishanth Menon <nm@...com>, Keerthy <j-keerthy@...com>,
        Jyri Sarha <jsarha@...com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        Lokesh Vutla <lokeshvutla@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Tony Lindgren <tony@...mide.com>, Tero Kristo <t-kristo@...com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 4/5] arm64: dts: ti: k3-am654-base-board: Fix up
 un-necessary status set to "okay" for USB

On 12/11/2020 03:49, Nishanth Menon wrote:
> The default state of a device tree node is "okay". There is no specific
> use of explicitly adding status = "okay" in the board dts.
> 
> Fixes: 7e7e7dd51d06 ("arm64: dts: ti: k3-am654-base-board: enable USB1")
> Signed-off-by: Nishanth Menon <nm@...com>
> Cc: Roger Quadros <rogerq@...com>

Acked-by: Roger Quadros <rogerq@...com>

cheers,
-roger
> ---
> Changes since v1:
> - no change.
> 
> v1: https://lore.kernel.org/linux-arm-kernel/20201104224356.18040-5-nm@ti.com/
> 
>   arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index 199c4d4e7539..744efcbb4f7f 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -325,14 +325,6 @@ &sdhci1 {
>   	disable-wp;
>   };
>   
> -&dwc3_1 {
> -	status = "okay";
> -};
> -
> -&usb1_phy {
> -	status = "okay";
> -};
> -
>   &usb1 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&usb1_pins_default>;
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki