[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20201113180701.455541-1-natechancellor@gmail.com>
Date: Fri, 13 Nov 2020 11:07:02 -0700
From: Nathan Chancellor <natechancellor@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Florian Fainelli <f.fainelli@...il.com>,
Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
Vladimir Oltean <olteanv@...il.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Lukas Wunner <lukas@...ner.de>,
Nick Desaulniers <ndesaulniers@...gle.com>,
linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
clang-built-linux@...glegroups.com,
Nathan Chancellor <natechancellor@...il.com>
Subject: [PATCH] spi: bcm2835aux: Restore err assignment in bcm2835aux_spi_probe
Clang warns:
drivers/spi/spi-bcm2835aux.c:532:50: warning: variable 'err' is
uninitialized when used here [-Wuninitialized]
dev_err(&pdev->dev, "could not get clk: %d\n", err);
^~~
./include/linux/dev_printk.h:112:32: note: expanded from macro 'dev_err'
_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
drivers/spi/spi-bcm2835aux.c:495:9: note: initialize the variable 'err'
to silence this warning
int err;
^
= 0
1 warning generated.
Restore the assignment so that the error value can be used in the
dev_err statement and there is no uninitialized memory being leaked.
Fixes: e13ee6cc4781 ("spi: bcm2835aux: Fix use-after-free on unbind")
Link: https://github.com/ClangBuiltLinux/linux/issues/1199
Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
---
drivers/spi/spi-bcm2835aux.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c
index fd58547110e6..1a26865c42f8 100644
--- a/drivers/spi/spi-bcm2835aux.c
+++ b/drivers/spi/spi-bcm2835aux.c
@@ -529,8 +529,9 @@ static int bcm2835aux_spi_probe(struct platform_device *pdev)
bs->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(bs->clk)) {
+ err = PTR_ERR(bs->clk);
dev_err(&pdev->dev, "could not get clk: %d\n", err);
- return PTR_ERR(bs->clk);
+ return err;
}
bs->irq = platform_get_irq(pdev, 0);
base-commit: c371dcf51cef4ae53d00090a148d004b113217f0
--
2.29.2
Powered by blists - more mailing lists