linux-kernel - Re: [PATCH] spi: bcm2835aux: Restore err assignment in bcm2835aux_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160529288073.31285.16420803496217581116.b4-ty@kernel.org>
Date:   Fri, 13 Nov 2020 18:41:20 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Lukas Wunner <lukas@...ner.de>,
        Vladimir Oltean <olteanv@...il.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Florian Fainelli <f.fainelli@...il.com>,
        clang-built-linux@...glegroups.com,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: bcm2835aux: Restore err assignment in bcm2835aux_spi_probe

On Fri, 13 Nov 2020 11:07:02 -0700, Nathan Chancellor wrote:
> Clang warns:
> 
> drivers/spi/spi-bcm2835aux.c:532:50: warning: variable 'err' is
> uninitialized when used here [-Wuninitialized]
>                 dev_err(&pdev->dev, "could not get clk: %d\n", err);
>                                                                ^~~
> ./include/linux/dev_printk.h:112:32: note: expanded from macro 'dev_err'
>         _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
>                                       ^~~~~~~~~~~
> drivers/spi/spi-bcm2835aux.c:495:9: note: initialize the variable 'err'
> to silence this warning
>         int err;
>                ^
>                 = 0
> 1 warning generated.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: bcm2835aux: Restore err assignment in bcm2835aux_spi_probe
      commit: d853b3406903a7dc5b14eb5bada3e8cd677f66a2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark