linux-kernel - Re: [PATCH 06/19] elf/vdso: Reuse arch_setup_additional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Nov 2020 14:57:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Dmitry Safonov <dima@...sta.com>, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Dmitry Safonov <0x7f454c46@...il.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Andy Lutomirski <luto@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, Borislav Petkov <bp@...en8.de>,
        Catalin Marinas <catalin.marinas@....com>,
        Christophe Leroy <christophe.leroy@...roup.eu>
Subject: Re: [PATCH 06/19] elf/vdso: Reuse arch_setup_additional_pages()
 parameters

Hi Dmitry,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on c34f157421f6905e6b4a79a312e9175dce2bc607]

url:    https://github.com/0day-ci/linux/commits/Dmitry-Safonov/Add-generic-user_landing-tracking/20201109-090354
base:    c34f157421f6905e6b4a79a312e9175dce2bc607
config: ia64-randconfig-r035-20201109 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/04586680978b048abe74dd892c5b1fcde7c486a3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dmitry-Safonov/Add-generic-user_landing-tracking/20201109-090354
        git checkout 04586680978b048abe74dd892c5b1fcde7c486a3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   WARNING: unmet direct dependencies detected for FRAME_POINTER
   Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
   Selected by
   - FAULT_INJECTION_STACKTRACE_FILTER && FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT && !X86_64 && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86
   In file included from arch/ia64/include/asm/pgtable.h:154,
   from include/linux/pgtable.h:6,
   from arch/ia64/include/asm/uaccess.h:40,
   from include/linux/uaccess.h:11,
   from include/linux/sched/task.h:11,
   from include/linux/sched/signal.h:9,
   from arch/ia64/kernel/asm-offsets.c:10:
   arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
   arch/ia64/include/asm/mmu_context.h:127:41: warning: variable 'old_rr4' set but not used
   127 | unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
   | ^~~~~~~
   In file included from arch/ia64/include/asm/sections.h:10,
   from include/linux/interrupt.h:20,
   from arch/ia64/include/asm/mca.h:17,
   from arch/ia64/kernel/asm-offsets.c:18:
   include/linux/elf.h: At top level:
   include/linux/elf.h:121:1: error: expected identifier or '(' before '{' token
   121 | {
   | ^
   arch/ia64/kernel/asm-offsets.c:23:6: warning: no previous prototype for 'foo'
   23 | void foo(void)
   | ^~~
   In file included from arch/ia64/include/asm/sections.h:10,
   from include/linux/interrupt.h:20,
   from arch/ia64/include/asm/mca.h:17,
   from arch/ia64/kernel/asm-offsets.c:18:
>> include/linux/elf.h:120:19: warning: 'arch_setup_additional_pages' declared 'static' but never defined
   120 | static inline int arch_setup_additional_pages(unsigned long
   | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   Makefile arch include kernel scripts source usr [scripts/Makefile.build:117: arch/ia64/kernel/asm-offsets.s] Error 1
   Target '__build' not remade because of errors.
   Makefile arch include kernel scripts source usr [Makefile:1198: prepare0] Error 2
   Target 'prepare' not remade because of errors.
   make: Makefile arch include kernel scripts source usr [Makefile:185: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

vim +120 include/linux/elf.h

   106	
   107	#ifdef CONFIG_ARCH_HAS_SETUP_ADDITIONAL_PAGES
   108	/**
   109	 * arch_setup_additional_pages - Premap VMAs in a new-execed process
   110	 * @sysinfo_ehdr:	Returns vDSO position to be set in the initial
   111	 *			auxiliary vector (tag AT_SYSINFO_EHDR) by binfmt
   112	 *			loader. On failure isn't initialized.
   113	 *			As address == 0 is never used, it allows to check
   114	 *			if the tag should be set.
   115	 *
   116	 * Return: Zero if successful, or a negative error code on failure.
   117	 */
   118	extern int arch_setup_additional_pages(unsigned long *sysinfo_ehdr);
   119	#else
 > 120	static inline int arch_setup_additional_pages(unsigned long *sysinfo_ehdr);
   121	{
   122		return 0;
   123	}
   124	#endif
   125	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (30922 bytes)