linux-kernel - Re: [PATCH 8/8] ARM: dts: socfgpa: Use generic "ngpios" rather than "snps,nr-gpios"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Nov 2020 07:48:56 -0600
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     Jisheng Zhang <Jisheng.Zhang@...aptics.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Khuong Dinh <khuong@...amperecomputing.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Wei Xu <xuwei5@...ilicon.com>
Cc:     linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Saravana Kannan <saravanak@...gle.com>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 8/8] ARM: dts: socfgpa: Use generic "ngpios" rather than
 "snps,nr-gpios"



On 11/9/20 3:07 AM, Jisheng Zhang wrote:
> This is to remove similar errors as below:
> 
> OF: /.../gpio-port@0: could not find phandle
> 
> Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> explained the reason of above errors well and added the generic
> "ngpios" property, let's use it.
> 
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
> ---
>  arch/arm/boot/dts/socfpga.dtsi         | 6 +++---
>  arch/arm/boot/dts/socfpga_arria10.dtsi | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 0b021eef0b53..32b7ad814ec6 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -612,7 +612,7 @@ porta: gpio-controller@0 {
>  				compatible = "snps,dw-apb-gpio-port";
>  				gpio-controller;
>  				#gpio-cells = <2>;
> -				snps,nr-gpios = <29>;
> +				ngpios = <29>;
>  				reg = <0>;
>  				interrupt-controller;
>  				#interrupt-cells = <2>;
> @@ -633,7 +633,7 @@ portb: gpio-controller@0 {
>  				compatible = "snps,dw-apb-gpio-port";
>  				gpio-controller;
>  				#gpio-cells = <2>;
> -				snps,nr-gpios = <29>;
> +				ngpios = <29>;
>  				reg = <0>;
>  				interrupt-controller;
>  				#interrupt-cells = <2>;
> @@ -654,7 +654,7 @@ portc: gpio-controller@0 {
>  				compatible = "snps,dw-apb-gpio-port";
>  				gpio-controller;
>  				#gpio-cells = <2>;
> -				snps,nr-gpios = <27>;
> +				ngpios = <27>;
>  				reg = <0>;
>  				interrupt-controller;
>  				#interrupt-cells = <2>;
> diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi
> index 0013ec3463c4..34e23e0582fb 100644
> --- a/arch/arm/boot/dts/socfpga_arria10.dtsi
> +++ b/arch/arm/boot/dts/socfpga_arria10.dtsi
> @@ -491,7 +491,7 @@ porta: gpio-controller@0 {
>  				compatible = "snps,dw-apb-gpio-port";
>  				gpio-controller;
>  				#gpio-cells = <2>;
> -				snps,nr-gpios = <29>;
> +				ngpios = <29>;
>  				reg = <0>;
>  				interrupt-controller;
>  				#interrupt-cells = <2>;
> @@ -511,7 +511,7 @@ portb: gpio-controller@0 {
>  				compatible = "snps,dw-apb-gpio-port";
>  				gpio-controller;
>  				#gpio-cells = <2>;
> -				snps,nr-gpios = <29>;
> +				ngpios = <29>;
>  				reg = <0>;
>  				interrupt-controller;
>  				#interrupt-cells = <2>;
> @@ -531,7 +531,7 @@ portc: gpio-controller@0 {
>  				compatible = "snps,dw-apb-gpio-port";
>  				gpio-controller;
>  				#gpio-cells = <2>;
> -				snps,nr-gpios = <27>;
> +				ngpios = <27>;
>  				reg = <0>;
>  				interrupt-controller;
>  				#interrupt-cells = <2>;
> 

Acked-by: Dinh Nguyen <dinguyen@...nel.org>