linux-kernel - Re: [PATCH 3/8] arm64: dts: bitmain: Use generic "ngpios" rather than "snps,nr-gpios"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Nov 2020 11:01:28 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Jisheng Zhang <Jisheng.Zhang@...aptics.com>
Cc:     Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Khuong Dinh <khuong@...amperecomputing.com>,
        Wei Xu <xuwei5@...ilicon.com>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Saravana Kannan <saravanak@...gle.com>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 3/8] arm64: dts: bitmain: Use generic "ngpios" rather
 than "snps,nr-gpios"

On Mon, Nov 09, 2020 at 05:04:31PM +0800, Jisheng Zhang wrote:
> This is to remove similar errors as below:
> 
> OF: /.../gpio-port@0: could not find phandle
> 
> Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> explained the reason of above errors well and added the generic
> "ngpios" property, let's use it.
> 
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

Thanks,
Mani

> ---
>  arch/arm64/boot/dts/bitmain/bm1880.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/bitmain/bm1880.dtsi b/arch/arm64/boot/dts/bitmain/bm1880.dtsi
> index fa6e6905f588..53a9b76057aa 100644
> --- a/arch/arm64/boot/dts/bitmain/bm1880.dtsi
> +++ b/arch/arm64/boot/dts/bitmain/bm1880.dtsi
> @@ -127,7 +127,7 @@ porta: gpio-controller@0 {
>  				compatible = "snps,dw-apb-gpio-port";
>  				gpio-controller;
>  				#gpio-cells = <2>;
> -				snps,nr-gpios = <32>;
> +				ngpios = <32>;
>  				reg = <0>;
>  				interrupt-controller;
>  				#interrupt-cells = <2>;
> @@ -145,7 +145,7 @@ portb: gpio-controller@0 {
>  				compatible = "snps,dw-apb-gpio-port";
>  				gpio-controller;
>  				#gpio-cells = <2>;
> -				snps,nr-gpios = <32>;
> +				ngpios = <32>;
>  				reg = <0>;
>  				interrupt-controller;
>  				#interrupt-cells = <2>;
> @@ -163,7 +163,7 @@ portc: gpio-controller@0 {
>  				compatible = "snps,dw-apb-gpio-port";
>  				gpio-controller;
>  				#gpio-cells = <2>;
> -				snps,nr-gpios = <8>;
> +				ngpios = <8>;
>  				reg = <0>;
>  				interrupt-controller;
>  				#interrupt-cells = <2>;
> -- 
> 2.29.2
>